Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong redirection for some products #7823

Closed
CharlesNepote opened this issue Dec 9, 2022 · 3 comments
Closed

Wrong redirection for some products #7823

CharlesNepote opened this issue Dec 9, 2022 · 3 comments
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality EAN-8 🎯 P1

Comments

@CharlesNepote CharlesNepote added 🐛 bug This is a bug, not a feature request. 🎯 P1 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Dec 9, 2022
@stephanegigandet
Copy link
Contributor

It's probably because we changed the normalization of barcodes at some point:

		# Remove 5 or 6 leading 0s for EAN8
		# 00000080050100 (from Ferrero)
		if ((length($code) eq 14) and ($code =~ /^000000/)) {
			$code = $';
		}
		if ((length($code) eq 13) and ($code =~ /^00000/)) {
			$code = $';
		}

codes that have only 5 digits that are non zeros are internal codes, and it's very likely that some of them will conflict with other products from other stores/brands.

we probably should remove most of them... those for instance:

image

@stephanegigandet
Copy link
Contributor

Those are from an old import of usda-ndb-import in 2018.

@alexgarel alexgarel self-assigned this Dec 14, 2022
@alexgarel
Copy link
Member

see #7249 and #7248 which should bring a solution to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality EAN-8 🎯 P1
Projects
Archived in project
Development

No branches or pull requests

4 participants