feat: deduce 0 sugar/sat fat to compute nutriscore #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where fat is 0 we can deduce saturated fat is 0, same for sugar from carbohydrates we use it to compute nutriscore
github-actions
bot
added
Food.pm
🚦Nutri-Score
lib/ProductOpener/Food.pm
Outdated
| # we have two special case where we can deduce data | ||
| next | ||
| if (saturated_fat_0_because_of_fat_0($product_ref, $prepared) | ||
| || sugar_0_because_of_carbohydrates_0($product_ref, $prepared)); |
There was a problem hiding this comment.
I think this will fail if you don't have both saturated_fat and sugars, but you have 1 of carbohydrates == 0 or fat == 0. You will get a Nutri-Score even though you can deduce only one of them.
There was a problem hiding this comment.
Is that ok @stephanegigandet (I added a test, so that should do)
CharlesNepote
approved these changes
Jan 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
stephanegigandet
approved these changes
Jan 10, 2023
teolemon
added
🚦 Nutri-Score
and removed
🚦Nutri-Score
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where fat is 0 we can deduce saturated fat is 0, same for sugar from carbohydrates we use it to compute Nutri-Score
Fixes: