-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script to fix non normalized codes #7953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
changed the title
feat: (wip) script to fix non normalized codes
feat: (wip) script to fix non normalized codes
Jan 6, 2023
alexgarel
changed the title
feat: (wip) script to fix non normalized codes
feat: script to fix non normalized codes
Jan 10, 2023
Hum, I'm not finished because there might be some non indexed entries after that (entries that where normalized but with an integer code in mongodb… |
- on file system - in mongodb
still need tests
+ better name for compute_keywords
alexgarel
force-pushed
the
fix-normalize-codes
branch
from
January 13, 2023 15:05
715dc51
to
8df2e83
Compare
So if you run it on a copy of the prod mongodb database, how many products would be affected for each case? |
Kudos, SonarCloud Quality Gate passed! |
stephanegigandet
approved these changes
Jan 18, 2023
Ok, I merge it, it will be easier for me to test it on staging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: