Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script to fix non normalized codes #7953

Merged
merged 9 commits into from
Jan 19, 2023
Merged

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Jan 6, 2023

@alexgarel alexgarel requested a review from a team as a code owner January 6, 2023 09:05
@alexgarel alexgarel marked this pull request as draft January 6, 2023 09:06
@alexgarel alexgarel changed the title feat: (wip) script to fix non normalized codes feat: (wip) script to fix non normalized codes Jan 6, 2023
@alexgarel alexgarel changed the title feat: (wip) script to fix non normalized codes feat: script to fix non normalized codes Jan 10, 2023
@alexgarel
Copy link
Member Author

Hum, I'm not finished because there might be some non indexed entries after that (entries that where normalized but with an integer code in mongodb…

@alexgarel alexgarel marked this pull request as ready for review January 13, 2023 23:24
@stephanegigandet
Copy link
Contributor

So if you run it on a copy of the prod mongodb database, how many products would be affected for each case?

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel
Copy link
Member Author

Ok, I merge it, it will be easier for me to test it on staging !

@alexgarel alexgarel merged commit 9920b07 into main Jan 19, 2023
@alexgarel alexgarel deleted the fix-normalize-codes branch January 19, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants