Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: adding Cocamidopropyl betaine in allergens #8070

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

fuddl
Copy link
Contributor

@fuddl fuddl commented Feb 5, 2023

I need to watch out for Cocamidopropyl betaine because I might be allergic to it. It wasn't yet listed as a allergent. According to Wikipedia the allergent status is controversial. 🤷

@fuddl fuddl requested a review from a team as a code owner February 5, 2023 08:36
@github-actions github-actions bot added the 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org label Feb 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel changed the title feat adding Cocamidopropyl betaine Taxonomy: adding Cocamidopropyl betaine in allergens Feb 6, 2023
@alexgarel
Copy link
Member

@stephanegigandet and @teolemon I think we have a precise policy for this allergens taxonomy. How is it ?

@benbenben2
Copy link
Collaborator

@fuddl, you have to prefix the title of your pull request by "taxonomy: " (all in lower case, it seems that the capital letter does not work)

@stephanegigandet
Copy link
Contributor

@stephanegigandet and @teolemon I think we have a precise policy for this allergens taxonomy. How is it ?

For food, we limit the allergens to the 14 or so allergens that must be marked on the package.

For cosmetics, we don't have an official list to rely on. The issue is that almost all ingredients can be allergens to some people, so instead of using the allergens taxonomy, it's probably better to rely on an ingredients taxonomy, and build features so that anyone can state which ingredients they are allergic to.

@fuddl fuddl changed the title Taxonomy: adding Cocamidopropyl betaine in allergens taxonomy: adding Cocamidopropyl betaine in allergens Feb 12, 2023
@alexgarel
Copy link
Member

@stephanegigandet I let you decide on this PR.

@fuddl by the way, whatever the decision is, thank you very much for opening the PR :-)

@stephanegigandet
Copy link
Contributor

We can add it. Note that Open Beauty Facts deployments are currently frozen, as we have not deployed the new design on OBF yet.

@stephanegigandet stephanegigandet merged commit fb7c352 into openfoodfacts:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants