Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New design on producers platform #8086

Merged
merged 38 commits into from
Feb 16, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Feb 9, 2023

This PR brings the new design to the producers platform.

Notable changes:

  • New colorful design :)
  • Product attributes shown on list of products + product summary page, according to user preferences
  • Personal scoring of products based on users preferences (if enabled by the user)
  • Knowledge panels on product pages

Also removed some dead code that was use in the old design (e.g. functions and templates used to generate blocks shown on the now defunct left sidebar).

Screenshots

image

image

image

image

@github-actions github-actions bot added Lists of products multilingual products product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users Web labels Feb 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #8086 (36be697) into main (eea81e5) will increase coverage by 0.15%.
The diff coverage is 10.52%.

@@            Coverage Diff             @@
##             main    #8086      +/-   ##
==========================================
+ Coverage   45.20%   45.36%   +0.15%     
==========================================
  Files         102      102              
  Lines       20272    20206      -66     
  Branches     4639     4626      -13     
==========================================
+ Hits         9164     9166       +2     
+ Misses      10011     9943      -68     
  Partials     1097     1097              
Impacted Files Coverage Δ
lib/ProductOpener/Lang.pm 19.84% <ø> (+0.72%) ⬆️
lib/ProductOpener/Users.pm 5.45% <ø> (ø)
lib/ProductOpener/Web.pm 31.19% <ø> (+6.90%) ⬆️
lib/ProductOpener/Display.pm 4.69% <10.52%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I added some screenshots
  • We should have the key actions inline as buttons (Import file…), otherwise the CTR is going to decrease

@stephanegigandet
Copy link
Contributor Author

  • We should have the key actions inline as buttons (Import file…), otherwise the CTR is going to decrease

We already have the "Import products" and "Export products" at the top of the front page:

image

We can add "Import photos" and turn the links to buttons.

@stephanegigandet
Copy link
Contributor Author

Now with buttons:

image

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool work.

I have some minor comments.

lib/ProductOpener/Web.pm Show resolved Hide resolved
<div class="row">
<div class="small-12 column v-space-short">
<div class="panel">
<p>[% lang('account_without_org') %]</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to also have a link to public platform here, for users that may get lost ?

<li><a href="/cgi/import_photos_upload.pl">[% lang('import_product_photos') %]</a></li>
<li><a href="/cgi/export_products.pl">[% lang('export_product_data_photos') %]</a></li>
<li><a href="/cgi/remove_products.pl">[% lang('remove_products_from_producers_platform') %]</a></li>
<li class="divider"></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A much wanted feature by @manon-corneille is a link to the user guide. Could we add it here ? (but it should be translatable string as the link differs between french and others (english for now)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I added a link to the user guide.

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephanegigandet stephanegigandet merged commit 6fa8b28 into main Feb 16, 2023
@stephanegigandet stephanegigandet deleted the pro-platform-new-design branch February 16, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks config CSS Display 📚 Documentation Documentation issues improve the project for everyone. 🎁 donations ✏️ Editing lang Lists of products product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users Web
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants