fix: escape issue in additives knowledge panel - remove latex formulas #8340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📖 Knowledge Panels
Codecov Report
@@ Coverage Diff @@
## main #8340 +/- ##
==========================================
+ Coverage 48.16% 48.17% +0.01%
==========================================
Files 109 110 +1
Lines 21015 21026 +11
Branches 4739 4739
==========================================
+ Hits 10122 10130 +8
- Misses 9618 9621 +3
Partials 1275 1275
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexgarel
approved these changes
Apr 21, 2023
| )* | ||
| } # match a closing } | ||
| ) | ||
| //xg; |
There was a problem hiding this comment.
So good you used extended format for regexp ❤️
There was a problem hiding this comment.
@alexgarel Well I adapted some code I found on Stack Overflow that had this extended format which is indeed quite cool. That's after ChatGPT gave me 3 wrong answers. ;)
github-actions
bot
added
Agribalyse
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
this particular wikipedia abstract is really not relevant to OFF, I would be very much in favor to creating our own additives descriptions.
Part of