fix: encode diffs as JSON text in send_notification_for_product_change
#8419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise `diffs=HASH(...)`
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #8419 +/- ##
=======================================
Coverage 48.51% 48.51%
=======================================
Files 114 114
Lines 21294 21296 +2
Branches 4773 4773
=======================================
+ Hits 10330 10332 +2
Misses 9679 9679
Partials 1285 1285
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stephanegigandet
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
diffs=HASH(...)Last PR I didn't test it locally...