Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vitamin b5 #8440

Merged
merged 2 commits into from
May 23, 2023
Merged

fix: update vitamin b5 #8440

merged 2 commits into from
May 23, 2023

Conversation

benbenben2
Copy link
Collaborator

@benbenben2 benbenben2 commented May 21, 2023

Make sure you've done all the following (You can delete the checklist before submitting)

  • PR title is prefixed by one of the following: feat, fix, docs, style, refactor, test, build, ci, chore, revert, l10n, taxonomy
  • Code is well documented
  • Include unit tests for new functionality
  • Code passes GitHub workflow checks in your branch
  • If you have multiple commits please combine them into one commit by squashing them.
  • Read and understood the contribution guidelines
    -->

What

Vitamin B5 (pantothenic acid) is displayed in the form's list of nutrients in "edit" mode.

It seems already there for French:
image

I updated all languages - having both vitamin b5 and pantothenic acid and me being able to read and understand it - to start with vitamin b5 (pantothenic acid)

Screenshot

image

Related issue(s) and discussion

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label May 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2023

Codecov Report

Merging #8440 (2ce9a9f) into main (6068ff9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8440   +/-   ##
=======================================
  Coverage   48.54%   48.54%           
=======================================
  Files         114      114           
  Lines       21314    21314           
  Branches     4776     4776           
=======================================
  Hits        10347    10347           
  Misses       9679     9679           
  Partials     1288     1288           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator Author

unrelated but there were commas in biotin entry for french

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexgarel alexgarel merged commit d5a60be into main May 23, 2023
@alexgarel alexgarel deleted the tax_pantothenic_acid branch May 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pantothenic acid is sometimes also referred as vitamin B5
3 participants