Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activate Japanese ingredients processing #8621

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

stephanegigandet
Copy link
Contributor

This PR builds upon the ingredients processing Japanese translations by @Naruyoko in #8617

The PR

  • enables ingredients processing parsing for Japanese: the processing is matched both before and after the ingredient, without requiring a space
  • adds some tests

@stephanegigandet stephanegigandet requested a review from a team as a code owner June 28, 2023 09:29
@github-actions github-actions bot added 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Jun 28, 2023
@stephanegigandet stephanegigandet added 🇯🇵 Japan https://jp.openfoodfacts.org/ and removed 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Jun 28, 2023
@github-actions github-actions bot added 🥗 Ingredients 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests labels Jun 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8621 (a167909) into main (5e0a136) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8621   +/-   ##
=======================================
  Coverage   48.69%   48.70%           
=======================================
  Files         114      114           
  Lines       21417    21421    +4     
  Branches     4791     4791           
=======================================
+ Hits        10430    10434    +4     
  Misses       9701     9701           
  Partials     1286     1286           
Impacted Files Coverage Δ
lib/ProductOpener/Ingredients.pm 90.79% <ø> (ø)
tests/unit/ingredients_processing.t 94.73% <100.00%> (+1.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Good idea to have added the English translations in ingredients_text.

I will approve it now, but don't forget to apply your comment in Slack:

Right, for that one, I think the right solution is to add クリーミングパウダー in the ingredients taxonomy, as "creaming" is not an ingredient.
クリーミングパウダー is listed as an ingredient in several Japanese products we have.

@stephanegigandet
Copy link
Contributor Author

I'll make a separate PR for the creaming powder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 🇯🇵 Japan https://jp.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants