Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: italien ingredient #8694

Merged
merged 5 commits into from
Jul 18, 2023
Merged

taxonomy: italien ingredient #8694

merged 5 commits into from
Jul 18, 2023

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Jul 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #8694 (029c9e4) into main (c8570c1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8694   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files         117      117           
  Lines       21819    21819           
  Branches     4860     4860           
=======================================
  Hits        10639    10639           
  Misses       9882     9882           
  Partials     1298     1298           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -35006,13 +35006,13 @@ ciqual_food_name:en:Apricot, pitted, dried
ciqual_food_name:fr:Abricot, dénoyauté, sec
#24 in 3 @2021-09-12

<en:apricot

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:+1: for removing apricot.
Shouldn't we add a parent ? like the one of almonds (en:tree nut) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it in tree nut, thank you

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

en:apricot kernels
de:Aprikosenkerne
es:huesos de albaricoque
fi:aprikoosinsiemen, aprikoosinsiemenet
fr:noyaux d'abricots, noyau d'abricot
it:Noccioli di Albicocca
it:Noccioli di albicocca, mandorle d'albicocca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it:Noccioli di albicocca, mandorle d'albicocca
it:Armelline, Noccioli di albicocca, mandorle d'albicocca

See https://it.wikipedia.org/wiki/Armellina

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 586c85d into main Jul 18, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the italien-ingredient branch July 18, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants