-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow Org admins to Remove Users from their Organization #8705
feat: Allow Org admins to Remove Users from their Organization #8705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good (:clap:), but I still got two functional problems:
- the user is removed from the org members list but his "org" field still have the organization inside. He can still access the org
--> you have to remove user from members and admins list, but also reset their "org" field.
- after hitting remove, organization edit the page is not displayed correctly
So after hitting remove, we get: That's because when the type is "user_delete", we don't set the template parameters for the org name and link:
They should be moved above the if condition for the type, so that they apply to both edit org and user delete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more small changes and there we are @MonalikaPatnaik
Thanks !
SonarCloud Quality Gate failed. 1 Bug No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @MonalikaPatnaik !
I think Alex changes have been addressed.
What
Building upon #8511 PR, added a separate column for deleting User and made a button alongside every user row which are associated to the organization.
Screenshot
Related issue(s) and discussion