Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: German ingredient #8717

Merged
merged 4 commits into from
Jul 24, 2023
Merged

taxonomy: German ingredient #8717

merged 4 commits into from
Jul 24, 2023

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Jul 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2023

Codecov Report

Merging #8717 (ce21d3c) into main (6bdb35b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8717   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         117      117           
  Lines       21866    21866           
  Branches     4866     4866           
=======================================
  Hits        10676    10676           
  Misses       9887     9887           
  Partials     1303     1303           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

taxonomies/ingredients.txt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -13698,6 +13698,11 @@ sl:modificiran koruzni škrob
sr:modifikovani kukuruzni skrob
sv:modifierad majsstärkelse

<en:modified starch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add "modified" and "partially modified" in ingredients_processing.txt, that way we could (eventually) remove all the related entries in ingredients.txt.

But let's merge this PR first, we can do it later.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet changed the title Taxonomy: German ingredient taxonomy: German ingredient Jul 24, 2023
@stephanegigandet stephanegigandet merged commit 961a116 into main Jul 24, 2023
14 of 15 checks passed
@stephanegigandet stephanegigandet deleted the german-ingredient branch July 24, 2023 11:52
@teolemon teolemon added the German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants