-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adding an integration test for the account deletion feature #8723
Conversation
adding a test for the user deletion feature in which : a common user is created the user adds a product then deletes his account an admin user is created and checks if the user account is well deleted (checking the edit preferences page and contributor page) the admin also checks if the product added by the user is anonymized (the product should display "anonymous" as creator) checking that no one can log in with the user logs
Codecov Report
@@ Coverage Diff @@
## main #8723 +/- ##
==========================================
+ Coverage 45.54% 45.58% +0.04%
==========================================
Files 64 64
Lines 19519 19549 +30
Branches 4738 4743 +5
==========================================
+ Hits 8889 8912 +23
- Misses 9454 9457 +3
- Partials 1176 1180 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
… to create a subprog in the module APITest.pm)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work, now let's improve a bit :-)
Thank you for your review @alexgarel, I'll work on the changes that have to be made |
I'm now working on writing a subprogram in the module APITest.pm which will essentially do the waiting part of the delete user task of my program |
I'm going to push my code with the troublesome issue I've been dealing with for the past few days. |
Co-authored-by: Alex Garel <[email protected]>
Co-authored-by: Alex Garel <[email protected]>
Co-authored-by: Alex Garel <[email protected]>
…nfoodfacts/openfoodfacts-server into albatrousse_delete_user_test
…nfoodfacts/openfoodfacts-server into albatrousse_delete_user_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small commit just to ensure consistency in get_minion_jobs.
Thank you @albatrousse !
Kudos, SonarCloud Quality Gate passed! |
adding a test for the user deletion feature in which :
currently working on assigning the deletion account part to a minion job and waiting it to be done before having an admin to check whether the account is well deleted or not