-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update the doc of makefile target with lint_perltidy #8883
Conversation
docker/README.md
Outdated
@@ -35,4 +35,9 @@ See also [targets to run tests](../docs/dev/how-to-write-and-run-tests.md#runnin | |||
| `make clean` | Clean up your dev environment: removes locally bound folders, run `hdown` and `prune`. | Run `make dev` to recreate a fresh dev env afterwards. | | |||
| `make import_sample_data` | Load sample data (~100 products) into the MongoDB database. | | | |||
| `make import_prod_data` | Load latest prod data (~2M products, 1.7GB) into the MongoDB database. | Takes up to 10m. Not recommended for dev setups ! | | |||
| `make lint_perltidy` | Indent and reformat your code | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just "make lint" ? Easier to remember/type, and make lint is running make lint_perltidy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is a good idea. I'll do this right now
Codecov Report
@@ Coverage Diff @@
## main #8883 +/- ##
=======================================
Coverage 45.54% 45.54%
=======================================
Files 64 64
Lines 19519 19519
Branches 4738 4738
=======================================
Hits 8889 8889
Misses 9454 9454
Partials 1176 1176 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
just casually adding a line with an explanation of the command
make lint_perltidy
and solution to a common issue with the latter command