Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xx: entries for ingredients matching #8891

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

fixes #8889

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #8891 (05bcfe2) into main (a801922) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #8891   +/-   ##
=======================================
  Coverage   45.54%   45.54%           
=======================================
  Files          64       64           
  Lines       19519    19519           
  Branches     4738     4738           
=======================================
  Hits         8889     8889           
  Misses       9454     9454           
  Partials     1176     1176           
Files Changed Coverage Δ
lib/ProductOpener/Tags.pm 40.60% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following screenshots show that it is working:

  1. xx: in taxonomy but not in hr:
    01_hr_not_in_taxonomy

  2. add this ingredient in a product in hr
    02_add_in_hr_product

  3. result: ingredient is recognized
    03_ingredient_is_recognized

Additional test. added a new product in ca language (ca:Lactobacil is in the taxonomy under en:Lactobacillus and xx:Lactobacillus) containing ingredient list "
Lactobacillus, Lactobacil". The first is in xx: and second in ca:. Result: both are recognized.

LGTM

@stephanegigandet
Copy link
Contributor Author

Thanks for the review and tests @benbenben2 !

@stephanegigandet stephanegigandet merged commit 9ea491c into main Aug 28, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the fix-xx-ingredients branch August 28, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xx: language less entries are not used for matching in the ingredients taxonomy
3 participants