fix: fix export excel with leading zero #9011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #9011 +/- ##
=======================================
Coverage ? 46.11%
=======================================
Files ? 64
Lines ? 19851
Branches ? 4795
=======================================
Hits ? 9155
Misses ? 9529
Partials ? 1167
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hangy
approved these changes
Sep 17, 2023
stephanegigandet
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Exported Excels do not contain leading zeros for the barcode.
Adding "$worksheet->keep_leading_zeros();" seems to solve the issue.
See: https://metacpan.org/pod/Spreadsheet::WriteExcel#keep_leading_zeros()
CSV seems not having this issue:
Screenshot
Result locally:
Related issue(s) and discussion