Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: German synonym for antioxydant #9030

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

moon-rabbitOFF
Copy link
Contributor

What

Screenshot

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Sep 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -211,7 +211,7 @@ bg: Антиоксидант, антиоксиданти
ca: Antioxidant, antioxidants, agent antienfosquiment
cs: Antioxidant, antioxidanty
da: Antioxidant, Antioxidanter
de: Antioxidant, Antioxidations-mittel, Antioxidationsmittel, Antioxidantien, Antioxidanzien
de: Antioxidant, Antioxidations-mittel, Antioxidationsmittel, Antioxidantsmittel, Antioxidantien, Antioxidanzien
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't heard this before, and Duden doesn't know it. I can't find too many Google matches, either. Do we have a lot of these typos on OFF?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's a typo, we should not add it as a synonym.

We do have 2 products with it, and it is indeed written on the package though: https://de.openfoodfacts.org/ingredient/Antioxidantsmittel

Is it a mispelling, or an actual synonym?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Rotweinessig, the text didn't match whats written on the label.

https://de.openfoodfacts.org/images/products/541/118/813/7955/3.jpg says "Antioxidationsmittel", https://de.openfoodfacts.org/images/products/541/118/813/7955/5.jpg says "Antioxidantsmittel", but I can't find that in a lot of sources or dictionaries. I think the producer might have created an incorrect label here. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word seems to exist (I can find it on some German websites), but is not common. Alpro is not a German brand, so I guess they didn't choose the best translation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed in Google there seems to be a number of product ingredients lists that have Antioxidantsmittel. In practice it does not hurt to add it, even if it's very uncommon.

@codecov-commenter
Copy link

Codecov Report

Merging #9030 (e3746a2) into main (11dd2d5) will increase coverage by 0.03%.
Report is 6 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #9030      +/-   ##
==========================================
+ Coverage   46.11%   46.14%   +0.03%     
==========================================
  Files          64       64              
  Lines       19850    19858       +8     
  Branches     4794     4796       +2     
==========================================
+ Hits         9154     9164      +10     
+ Misses       9529     9527       -2     
  Partials     1167     1167              
Files Changed Coverage Δ
lib/ProductOpener/Images.pm 12.73% <ø> (ø)
lib/ProductOpener/Users.pm 7.12% <28.57%> (+2.07%) ⬆️
lib/ProductOpener/Ingredients.pm 92.04% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet changed the title German synonym for antioxydant taxonomy: German synonym for antioxydant Sep 20, 2023
@stephanegigandet stephanegigandet merged commit a62a825 into main Sep 22, 2023
13 of 15 checks passed
@stephanegigandet stephanegigandet deleted the moon-rabbitOFF-patch-5 branch September 22, 2023 07:42
@teolemon teolemon added the German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
additives classes 🧪 additives German https://wiki.openfoodfacts.org/Local_Communities/GermanTeam 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants