Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add padding between tabs #9084

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: add padding between tabs #9084

merged 1 commit into from
Sep 28, 2023

Conversation

Valimp
Copy link
Collaborator

@Valimp Valimp commented Sep 28, 2023 •
edited
Loading

What

Add 1rem of "margin bottom" to fix the responsive issue

Screenshot

Before :
before_mobile
before_laptop
After :
after_mobile
after_laptop

@raphael0202

@Valimp Valimp requested a review from a team as a code owner September 28, 2023 09:02
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies CSS labels Sep 28, 2023
raphael0202
raphael0202 requested changes Sep 28, 2023
View reviewed changes
scss/sveetoy/components/_buttons.scss Outdated Show resolved Hide resolved
taxonomies/nutrient_levels.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot added Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. and removed 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Sep 28, 2023
@Valimp Valimp changed the title fix:add_padding_between_tab Fixes#7495 fix: addpadding_between_tab Fixes#7495 Sep 28, 2023
@Valimp Valimp changed the title fix: addpadding_between_tab Fixes#7495 fix: add padding between tabs Fixes#7495 Sep 28, 2023
@Valimp Valimp changed the title fix: add padding between tabs Fixes#7495 fix: add padding between tabs Sep 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@raphael0202
Copy link
Contributor

LGTM, congrats for your first contribution! 🎉

@raphael0202 raphael0202 enabled auto-merge (squash) September 28, 2023 09:51
@raphael0202 raphael0202 merged commit 0abdc97 into main Sep 28, 2023
15 of 17 checks passed
@raphael0202 raphael0202 deleted the fix_7495_not_enough_padding branch September 28, 2023 10:23
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael0202 raphael0202 raphael0202 approved these changes

Assignees

@Valimp Valimp

Labels
CSS Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NEW DESIGN - Not enough padding between tabs in edit mode in responsive view
2 participants
@Valimp @raphael0202