taxonomy: More german ingredient #9094
Conversation
github-actions
bot
added
🧬 Taxonomies
Codecov Report
@@ Coverage Diff @@
## main #9094 +/- ##
==========================================
+ Coverage 47.85% 47.91% +0.05%
==========================================
Files 64 64
Lines 19965 20003 +38
Branches 4833 4843 +10
==========================================
+ Hits 9554 9584 +30
- Misses 9163 9168 +5
- Partials 1248 1251 +3 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
teolemon
added
the
German
taxonomies/ingredients.txt
Outdated
| @@ -43538,6 +43543,11 @@ fr:Framboises entières | |||
| nl:hele frambozen | |||
| # 10@2019-06-07 | |||
|
|
|||
| <en:raspberry | |||
| en:raspberry pieces | |||
| de:Himbeerstücke | |||
There was a problem hiding this comment.
We should try not to add entries like "something pieces", and use the ingredients_processing.txt instead.
Here it doesn't work because in ingredients.txt we have
de:Himbeeren, Himbeere
If we add "Himbeer" as a synonym in ingredients.txt, then we will recognize Himbeerstücke automatically because we have a processing for it:
en:pieces
bg:парчета, парченца, парченца от
ca:peça, peces, trossos de, trossos d', guarnició
af:stukkies
de:stücke, stücken, stückchen, gestückelt, stück
I don't know German unfortunately, so I'm hoping it's fine to put "Himbeer" without an "e" in the synonyms?
There was a problem hiding this comment.
Okay I removed it from the pull request. Himbeer without "e" doesn't exist as a word in itself, but in compound words the "e" is removed to attached both words together
There was a problem hiding this comment.
Thanks, let's merge this PR as is, I filed a bug to try to improve the compound words issue: #9115
stephanegigandet
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
What
Screenshot
Related issue(s) and discussion