-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: more spacing in edit preferences form #9097
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9097 +/- ##
==========================================
+ Coverage 47.85% 47.95% +0.10%
==========================================
Files 64 64
Lines 19965 20013 +48
Branches 4833 4850 +17
==========================================
+ Hits 9554 9597 +43
- Misses 9163 9168 +5
Partials 1248 1248 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
html/js/product-preferences.js
Outdated
@@ -222,10 +223,12 @@ function display_user_product_preferences(target_selected, target_selection_form | |||
checked = ' checked'; | |||
} | |||
|
|||
attribute_group_html += "<div class='attribute_item'>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't you add it below instead of adding a new attribute_group_html +=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #7492
What
Add 1rem of margin bottom to close button and "Classify products according to your preferences"
Screenshot
Related issue(s) and discussion
@raphael0202