Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: frontend fixed #9203

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix: frontend fixed #9203

merged 2 commits into from
Oct 26, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Oct 26, 2023 •
edited
Loading

What

A few CSS issues that needed fixing:

  • the path for playstore badges were not commited (only in prod server), I switched to the file paths that really exists on the repo
  • the mobile banner margin was incorrect + remove radius
  • fix spacing issues in footer links

Screenshot

Mobile banner (before/after)

Capture d’écran 2023-10-26 à 10 33 46
Capture d’écran 2023-10-26 à 10 33 48

Footer (before/after)

Capture d’écran 2023-10-26 à 10 34 07
Capture d’écran 2023-10-26 à 10 34 02

@raphael0202
fix: use correct path for playstore badges
7e6643d
@raphael0202
fix: fix CSS issues
4755422 
- top mobile banner margin & border radius was incorrect
- fix spacing issue in footer links
@raphael0202 raphael0202 requested a review from a team as a code owner October 26, 2023 08:32
@github-actions github-actions bot added CSS Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Oct 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #9203 (4755422) into main (bd6b3da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9203   +/-   ##
=======================================
  Coverage   47.95%   47.95%           
=======================================
  Files          65       65           
  Lines       20223    20223           
  Branches     4914     4914           
=======================================
  Hits         9697     9697           
  Misses       9271     9271           
  Partials     1255     1255

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alexgarel alexgarel merged commit 7062fd8 into main Oct 26, 2023
16 checks passed
@alexgarel alexgarel deleted the frontend-fixes branch October 26, 2023 15:48
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@raphael0202 raphael0202

Labels
CSS Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raphael0202 @codecov-commenter @stephanegigandet @alexgarel