-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: Added unknown Croatian ingredients to the taxonomy (part 9) #9236
Conversation
@@ -1851,6 +1855,32 @@ hr:rafinirano, djelomično rafinirano | |||
#fr:Dessucré, partiellement dessucré | |||
#hr:bez šećera, sa smanjenom količinom šećera | |||
|
|||
en:Homogenization, homogenisation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this entry should be "Homogenized", not "Homogenization"
taxonomies/ingredients.txt
Outdated
@@ -208,6 +209,7 @@ pl:proszek karmelowy, karmel w proszku | |||
pt:caramelo em pó | |||
# ingredient/fr:caramel-en-poudre has 69 products in 5 languages @2019-03-09 | |||
|
|||
<en:preparation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this change, but "caramel chocolate preparation" should not be under E150 I think
Another option woul be to make "preparation", "filling" and "coating" ingredients processing instead. That way we don't have to add entries for basically all fruits, vegetables etc. ("strawberry preparation" and so on) and their translations in all languages. We will have to be careful when counting % of fruits and vegetables (e.g. "strawberry preparation 50% (strawberries, water, sugar)" should not count as 50% of fruits), but it can be done easily. |
In principle I am not in favour to put it in processing, as the idea was that a processing step would not influence the characteristics of an ingredient. For filling this is not the case (strawberry and strawberry filling are only related on one ingredient. |
Good point from @aleene "strawberry filling" may be related to more than one ingredient. For example, this "apple filling" (Punjenje od jabuke) contains more than apple: https://hr.openfoodfacts.org/product/3856021206184/pita-of-jabuka-s-budget |
Some queries that are useful to see what kind of fillings etc. we have in ingredients lists: |
We could have a compound taxonomy that we use for ingredient parsing. Whenever we see "[something] preparation" (or filling, cover etc.), we map it to an ingredient id "preparation". Same for "préparation [something]" in French etc. Today we have things like:
And we would replace them with:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9236 +/- ##
=======================================
Coverage 48.68% 48.68%
=======================================
Files 65 65
Lines 20268 20268
Branches 4896 4896
=======================================
Hits 9867 9867
Misses 9141 9141
Partials 1260 1260 ☔ View full report in Codecov by Sentry. |
This is a good idea. |
@benbenben2 I think we can merge as-is (maybe change "homogenization" to "homogenized" in the ingredients processing first). I'm filing a bug for the proposal to deal with compounds. |
New issue for the parsing of "xyz preparation": #9345 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Kudos, SonarCloud Quality Gate passed! |
What
added HR in taxonomy
seems to me that we could make difference between:
I tried to apply changes accordingly
Also wondering if we could merge preparation and filling? Can we say that preparations are fillings? As it is not clear to me (there is term en:compound as well), I made all preparations as children of en:preparation (although preparation alone does not exists).
Related issue(s) and discussion