fix: dq_serving_size_cant_be_parsed #9462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧬 Taxonomies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9462 +/- ##
=======================================
Coverage 49.00% 49.01%
=======================================
Files 66 66
Lines 20421 20422 +1
Branches 4904 4905 +1
=======================================
+ Hits 10008 10009 +1
Misses 9144 9144
Partials 1269 1269 ☔ View full report in Codecov by Sentry. |
benbenben2
force-pushed
the
dq_serving_size_cant_be_parsed
branch
from
c600bb9
to
8a4fdef
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
stephanegigandet
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated the existing "en:nutrition-data-per-serving-serving-quantity-is-not-recognized" facet
To be triggered even if nutrition data or per portion are not checked.
Existing unit tests are still valid
Added one unit tests covering the case when only serving_size is given (per portion is not checked, nutrition table is empty)
Related issue(s) and discussion
serving_sizewithout units #9116