fix: dq_nutrition_rm_salt_under_01g #9464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbenben2
added
🧽 Data quality
github-actions
bot
added
🧬 Taxonomies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9464 +/- ##
==========================================
+ Coverage 49.00% 49.02% +0.01%
==========================================
Files 66 66
Lines 20421 20420 -1
Branches 4904 4904
==========================================
+ Hits 10008 10010 +2
+ Misses 9144 9142 -2
+ Partials 1269 1268 -1 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
stephanegigandet
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
remove quality warning for salt under 0.1g
remaing quality warnings: salt under 0.01g and 0.001g
note that the warnings aim to detect if values could have been given in mg instead of g.
Related issue(s) and discussion
Nutrition value under 0.1 g saltwarning is counterproductive for the majority of the cases #9346