Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Update ingredients parsing for Spanish and Catalan #9476

Merged
merged 3 commits into from
Dec 12, 2023
Merged

taxonomy: Update ingredients parsing for Spanish and Catalan #9476

merged 3 commits into from
Dec 12, 2023

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Dec 5, 2023

Added strings parsing for Spanish and Catalan.

@duhow duhow requested a review from a team as a code owner December 5, 2023 15:31
stephanegigandet
stephanegigandet approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benbenben2
Copy link
Collaborator

@duhow, you need to run "make lint" locally.
Then, add updated files, commit and push. That should solve the current error of perltidy.

@stephanegigandet stephanegigandet enabled auto-merge (squash) December 12, 2023 12:24
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit e9eda67 into openfoodfacts:main Dec 12, 2023
13 checks passed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@duhow duhow

Labels
ingredients analysis 🥗 Ingredients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duhow @benbenben2 @stephanegigandet