Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add ingredient translations #9481

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Dec 5, 2023

What

taxonomy: add ingredient translations

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients labels Dec 5, 2023
@@ -23557,11 +23573,35 @@ allergens:en: en:gluten

<en:barley
en:organic barley
hr:organski ječam
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hr exists already, add as synonym instead


<en:barley
en:sprouted barley
pl:jęczmień kiełkowany
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pl exists already, add as synonym instead

@aleene
Copy link
Contributor

aleene commented Dec 10, 2023

I think all the organic entries can be removed. They are parsed in another way. An entry is only needed if the parser can not handle the complexity of the language (often German).

Comment on lines 22972 to 22974
fr:semolina di grano duro bianca biologica
fr:biologische weiße Hartweizengrieß
fr:sémola de trigo duro blanca orgánica
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fr:semolina di grano duro bianca biologica
fr:biologische weiße Hartweizengrieß
fr:sémola de trigo duro blanca orgánica
it:semolina di grano duro bianca biologica
de:biologische weiße Hartweizengrieß
es:sémola de trigo duro blanca orgánica

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, cannot apply you changes:
"This diff has recently been updated. Refresh and try again"
Of course, refresh does not change anything :(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for all suggestions
also if I add suggestion to batch
sorry :(

@@ -23557,11 +23573,35 @@ allergens:en: en:gluten

<en:barley
en:organic barley
hr:organski ječam
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hr:organski ječam

de:Bio-Gerste
es:cebada orgánica
fi:luomuohra
hu:bio árpa
hr:eko ječam
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hr:eko ječam
hr:eko ječam, organski ječam

hu:csíráztatott árpa
it:Orzo germogliato
nl:gekiemde gerst
nn:spiret bygg
pl:kiełki jęczmienia
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pl:kiełki jęczmienia
pl:kiełki jęczmienia, jęczmień kiełkowany


<en:barley
en:sprouted barley
pl:jęczmień kiełkowany
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pl:jęczmień kiełkowany

Comment on lines 23346 to 23348
fr:semolina di grano duro bianca biologica
fr:biologische weiße Hartweizengrieß
fr:sémola de trigo duro blanca orgánica
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fr:semolina di grano duro bianca biologica
fr:biologische weiße Hartweizengrieß
fr:sémola de trigo duro blanca orgánica
it:semolina di grano duro bianca biologica
de:biologische weiße Hartweizengrieß
es:sémola de trigo duro blanca orgánica


<en:barley
en:sprouted barley
pl:jęczmień kiełkowany
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pl:jęczmień kiełkowany

hu:csíráztatott árpa
it:Orzo germogliato
nl:gekiemde gerst
nn:spiret bygg
pl:kiełki jęczmienia
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pl:kiełki jęczmienia
pl:jęczmień kiełkowany, kiełki jęczmienia

@@ -23937,11 +23949,35 @@ allergens:en: en:gluten

<en:barley
en:organic barley
hr:organski ječam
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hr:organski ječam

de:Bio-Gerste
es:cebada orgánica
fi:luomuohra
hu:bio árpa
hr:eko ječam
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hr:eko ječam
hr:organski ječam, eko ječam

@teolemon
Copy link
Member Author

I applied the fixes manually @benbenben2

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@benbenben2 benbenben2 merged commit 2651bfa into main Dec 19, 2023
12 checks passed
@benbenben2 benbenben2 deleted the ingredient-translations branch December 19, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants