-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: OpenAPI nutrients enhancements #9513
Conversation
7157221
to
c4636d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9513 +/- ##
=======================================
Coverage 49.02% 49.02%
=======================================
Files 66 66
Lines 20434 20434
Branches 4905 4905
=======================================
Hits 10018 10018
Misses 9147 9147
Partials 1269 1269 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
The nutrition data on the package can be per serving or per 100g. | ||
|
||
This is essential to understand if `<nutrient>_value` and `<nutrient>` | ||
values in `nutriments` applies for a serving or for 100g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add something like: "When writing products, this setting applies to all existing nutrients values for the product, not only the nutrient values sent in the write request. So it should not be changed unless all nutrients values are provided with values that match the nutrition_data_per field."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added one suggestion.
Kudos, SonarCloud Quality Gate passed! |
No description provided.