Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: new ingredients for the Contribalim project #9562

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

stephanegigandet
Copy link
Contributor

No description provided.

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels 🥗 Ingredients labels Dec 20, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b387293) 49.24% compared to head (3634128) 49.24%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9562   +/-   ##
=======================================
  Coverage   49.24%   49.24%           
=======================================
  Files          66       66           
  Lines       20532    20532           
  Branches     4944     4944           
=======================================
  Hits        10112    10112           
  Misses       9132     9132           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if
<en:cream cheese
should not be replaced by
<en:soft white cheese (fromage frais in FR).

What do you think?

Comment on lines 7139 to 7142
<en:cream cheese
en:fresh cream cheese

<en:fresh cream cheese
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<en:cream cheese
en:fresh cream cheese
<en:fresh cream cheese
<en:soft white cheese

ciqual_proxy_food_name:en:Petit-Suisse like fresh cream cheese, plain, around 9% fat
ciqual_proxy_food_name:fr:Fromage frais type petit suisse, nature, 10% MG environ

<en:fresh cream cheese
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<en:fresh cream cheese
<en:soft white cheese

@stephanegigandet
Copy link
Contributor Author

I wonder if
<en:cream cheese
should not be replaced by
<en:soft white cheese (fromage frais in FR).

Maybe, I don't know. We can replace it. I don't really know the difference between "soft white cheese / fromage frais" and "cream cheese / fromage à la crème".

@stephanegigandet stephanegigandet enabled auto-merge (squash) December 21, 2023 09:09
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit 01f36ba into main Dec 21, 2023
12 checks passed
@stephanegigandet stephanegigandet deleted the contribalim-ingredients branch December 21, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribalim 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants