Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: upd categories to reflect EU regulations #9601

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

benbenben2
Copy link
Collaborator

@benbenben2 benbenben2 commented Dec 26, 2023

What

In EU,
naming jams (jellies) or extra-jams (extra-jellies) are restricted for speficic content of fruit.
marmalade is restricted for citrus fruits (i.e. marmerlade = citrus jam)

Tried to update the taxonomy for categories accordingly.

  • Put jams, extra-jams, jellies, extra-jellies and marmalade, all as child of <en:Fruit and vegetable preserves
  • fusioned citrus jam and marmalades
  • order jams and jellies in alphabetical order
  • surprisingly, "beer jam" category products are really jam, having content of fruit written on the package
  • surprisingly, "milk jam" category products does not have content of fruit written but "milk jam" is really written on the package
  • I did not duplicate all entries for jams (jellies) to include their extra-jams (extra-jellies) equivalent yet but I think we should at some point.
  • I did not add marmalade jellies in the taxonomy.

See for more details: https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX%3A02001L0113-20131118

Related issue(s) and discussion

@benbenben2 benbenben2 self-assigned this Dec 26, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories 🥗 Ingredients labels Dec 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f95f746) 49.28% compared to head (0083d38) 49.28%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9601   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files          66       66           
  Lines       20546    20546           
  Branches     4946     4946           
=======================================
  Hits        10126    10126           
  Misses       9132     9132           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benbenben2
Copy link
Collaborator Author

Split marmalades and citrus jams as 2 separates categories, until EU update its regulations

See discussion in slack

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit a76af70 into main Jan 24, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the dq_category_specific_ingredient_percent branch January 24, 2024 10:05
john-gom pushed a commit that referenced this pull request May 24, 2024
* upd categories to reflect EU regulations

* split marmalades and citrus jams

* rm duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants