Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add z-index for sugar warning #8477 #9617

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

TCatinaud
Copy link
Collaborator

What

Problem: If a user enters a wrong value for energy, the label explaining the warning on energy is hidden by the nutrition image.
Solution: Add the property z-index at the label (class .sugar_warning).

Screenshot

Before fix:
8477-ko

After fix:
8477-ok

Related issue(s) and discussion

@TCatinaud TCatinaud requested a review from a team as a code owner January 4, 2024 09:52
@github-actions github-actions bot added ✏️ Editing Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Jan 4, 2024
@TCatinaud TCatinaud added the CSS label Jan 4, 2024
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8cb4f4) 49.28% compared to head (0375644) 49.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9617   +/-   ##
=======================================
  Coverage   49.28%   49.28%           
=======================================
  Files          66       66           
  Lines       20546    20546           
  Branches     4946     4946           
=======================================
  Hits        10126    10126           
  Misses       9132     9132           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TCatinaud TCatinaud removed their assignment Jan 4, 2024
@alexgarel
Copy link
Member

thank you so much @TCatinaud !

@alexgarel alexgarel merged commit 7ed1019 into main Jan 5, 2024
13 checks passed
@alexgarel alexgarel deleted the warning-explanation-under-nutrition-image branch January 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS ✏️ Editing Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning explanation on nutriments is displayed under the nutrition image and not visible
4 participants