fix: fix_dq_facet_all_values_identical

[benbenben2]

What

Bug reported on Slack
Sometimes the unit test 'all identical values and above 1 in the nutrition table 2' in dataqualityfood.t fails.

It happens because the array "@major_nutriments_values" (see Ingredients.pm) can have values in random order. Sometimes the first value is "0.8" and since we have the condition "@major_nutriments_values[0] > 1" facet is not raised. And test fails.

See the code for suggested solution

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55a9b22) 49.54% compared to head (7b817f1) 49.54%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9722   +/-   ##
=======================================
  Coverage   49.54%   49.54%           
=======================================
  Files          67       67           
  Lines       20650    20650           
  Branches     4980     4980           
=======================================
  Hits        10231    10231           
  Misses       9131     9131           
  Partials     1288     1288           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stephanegigandet]

In addition, I think you should add a sort in there:

foreach my $nid (keys %{$product_ref->{nutriments}}) {

->

foreach my $nid (sort keys %{$product_ref->{nutriments}}) {

So that we always go in the same order.

[stephanegigandet]

Suggested change

	and (@major_nutriments_values[0] > 1)
	and ($major_nutriments_values[0] > 1)

This currently causes a warning in the main branch:

Scalar value @major_nutriments_values[0] better written as $major_nutriments_values[0] at /opt/product-opener/lib/ProductOpener/DataQualityFood.pm line 1171.

[benbenben2]

done.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[stephanegigandet]

Thanks!