Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nutri-Score v2 fixes and improvements to knowledge panels #9795

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

stephanegigandet
Copy link
Contributor

  • use "undef" in the nutridscore data instead of 0 for fiber, fruits/vegetables/legumes values etc. when they are not known
  • in the Nutri-Score panel, display "unknown" instead of 0 when a nutrient is unknown
  • count the number of non-nutritive sweeteners (for beverages) and display it, instead of just indicating absence / presence
  • fixes some warnings including Warnings when computing Nutri-Score #9781
  • add some missing strings in en.po
  • some bug fixes for special cases (like spring water with no nutrition data, where we do display Nutri-Score A anyway)

image

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner February 13, 2024 13:45
@github-actions github-actions bot added 📚 Documentation Documentation issues improve the project for everyone. 🧪 tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Food.pm Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display Numbers ingredients analysis 🚦 Nutri-Score 🌐 Translations 🥗 Ingredients labels Feb 13, 2024
@teolemon
Copy link
Member

teolemon commented Feb 14, 2024

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good !

Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Display 📚 Documentation Documentation issues improve the project for everyone. Food.pm ingredients analysis 🥗 Ingredients 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Numbers 🚦 Nutri-Score Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations
Projects
Development

Successfully merging this pull request may close these issues.

3 participants