feat: Revert product to a previous revision (API + upcoming website integration for moderators) #9800
Conversation
github-actions
bot
added
API
|
Can we have some kind of log/notification when a moderator reverts a product ? |
github-actions
bot
added
🧬 Taxonomies
I'm sending a mail to admins, we can revisit once we have a better system in place for events / notifications / patrol. |
stephanegigandet
changed the title
github-actions
bot
added
📚 Documentation
There was a problem hiding this comment.
Good idea to add this module ! This will bring clarity.
lib/ProductOpener/Display.pm
Outdated
| if ($User{moderator}) { | ||
| $request_ref->{moderator} = 1; | ||
| } | ||
| else { | ||
| $request_ref->{moderator} = 0; | ||
| } | ||
|
|
||
| if ($User{pro_moderator}) { | ||
| $request_ref->{pro_moderator} = 1; | ||
| } | ||
| else { | ||
| $request_ref->{pro_moderator} = 0; | ||
| } |
There was a problem hiding this comment.
| if ($User{moderator}) { | |
| $request_ref->{moderator} = 1; | |
| } | |
| else { | |
| $request_ref->{moderator} = 0; | |
| } | |
| if ($User{pro_moderator}) { | |
| $request_ref->{pro_moderator} = 1; | |
| } | |
| else { | |
| $request_ref->{pro_moderator} = 0; | |
| } | |
| $request_ref->{moderator} = !!$User{moderator}; | |
| $User{pro_moderator} = !!$request_ref->{pro_moderator}; |
There was a problem hiding this comment.
Here I wanted to set the value to 0 specifically, but we can use undef instead (!! 0 or !! undef seems to be equal to undef)
lib/ProductOpener/Display.pm
Outdated
| $scripts .= <<SCRIPTS | ||
| <script>var revert_confirm_message = "$revert_confirm";</script> | ||
| <script src="$static_subdomain/js/dist/product-history.js"></script> | ||
| SCRIPTS | ||
| ; | ||
|
|
||
| $initjs .= <<JS | ||
| activate_product_revert_buttons_in_history(); | ||
| JS | ||
| ; |
There was a problem hiding this comment.
Don't we want to avoid this kind of JS inclusion (I find it quite annoying) ?
Why isn't it included in the template. Or we could maybe just use a specific class to trigger the JS activity.
There was a problem hiding this comment.
OK, I'm moving it.
taxonomies/nutrient_levels.txt
Outdated
| @@ -138,7 +138,7 @@ qu:Wira in low quantity | |||
| rm:Fat in low quantity | |||
| rn:Fat in low quantity | |||
| ro:Grăsimi în cantitate mică | |||
| ru:Жиры в небольшое количество | |||
| ru:Жиры в в малом количестве | |||
There was a problem hiding this comment.
? why is the в repeated ?
(see also below)
There was a problem hiding this comment.
FYI, it seems to come from taxonomy generations…
There was a problem hiding this comment.
@alexgarel I made a PR to remove this file from GitHub: #9851
| { | ||
| test_case => 'revert-product-no-code', | ||
| method => 'POST', | ||
| path => '/api/v3/product_revert', | ||
| body => '{ | ||
| "rev": 1, | ||
| "fields": "code,rev,product_name_en,brands_tags,categories_tags" | ||
| }', | ||
| ua => $moderator_ua, | ||
| }, |
There was a problem hiding this comment.
I don't see a specific return code. Does this mean we send back a 200 ? I think this is important to return a non 20x code (to keep REST like and ease handling by a lot of languages, JS included).
There was a problem hiding this comment.
Good point, I'm changing to 40x codes for errors
github-actions
bot
added
API WRITE
|
|
||
| foreach my $test_ref (@$tests_ref) { | ||
|
|
||
| my $response = execute_request($test_ref, $ua); |
There was a problem hiding this comment.
You did an incredible job at refactoring. Sorry if it feels picky, but I still have a request: I would check the expected code response even in case of setup, it can help understanding that a test fails because a setup test did go wrong.
There was a problem hiding this comment.
Good idea. So for setup test cases, I now still call check_requests_response (so that we can check expected status code), but I don't save or compare the actual response body.
github-actions
bot
removed
🧬 Taxonomies
|
|
🎉 |
…ntegration for moderators) (#9800)
Will fix #1405
Still missing: