Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Addition of privacy link, and translatable strings #9776 #9804

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

aadak99
Copy link
Contributor

@aadak99 aadak99 commented Feb 16, 2024

What

Added privacy policy link in addition to translatable strings into .pot and en.po

Screenshot

image

Related issue(s) and discussion

@aadak99 aadak99 requested a review from a team as a code owner February 16, 2024 06:17
@github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌐 Translations Site layout labels Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc04d18) 49.54% compared to head (cec423f) 49.54%.
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9804      +/-   ##
==========================================
- Coverage   49.54%   49.54%   -0.01%     
==========================================
  Files          67       67              
  Lines       20650    20751     +101     
  Branches     4980     4998      +18     
==========================================
+ Hits        10231    10281      +50     
- Misses       9131     9180      +49     
- Partials     1288     1290       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet changed the title Fix: Addition of privacy link, and translatable strings #9776 fix: Addition of privacy link, and translatable strings #9776 Feb 19, 2024
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 59bc324 into openfoodfacts:main Feb 19, 2024
13 of 14 checks passed
john-gom pushed a commit that referenced this pull request May 24, 2024
privacy policy link addition, and translatable strings to common.pot/en.po
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site layout Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🌐 Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a link to the privacy policy in the footer
3 participants