fix: pull request action, needs build_taxonomies before running tests #9883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
GitHub Actions
github-actions
bot
removed
the
GitHub Actions
alexgarel
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
I changed your PR to an approached that seems more robust & generic to me @stephanegigandet
|
This was referenced Mar 7, 2024
john-gom
pushed a commit
that referenced
this pull request
May 24, 2024
* fix: compile nutrients_level in build_lang It looks like the nutrient_levels taxonomy has not already been generated when tests are run. It should work anyway but it fails for some reason. This seems to happen only for the first test case, and only sometimes, maybe a race condition. --------- Co-authored-by: Alex Garel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the nutrient_levels taxonomy has not already been generated when tests are run. It should work anyway but it fails for some reason.
e.g. https://github.com/openfoodfacts/openfoodfacts-server/actions/runs/8189813679/job/22395977705?pr=9854
Container po_off_test-memcached-1 Running
Could not load taxonomy: /mnt/podata/taxonomies/nutrient_levels.result.sto at /opt/product-opener/lib/ProductOpener/Tags.pm line 2507.
Compilation failed in require at tests/unit/additives_tags.t line 9.
This seems to happen only for the first test case, and only sometimes, maybe a race condition.