Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: fix taxonomies for lines double for same langage #9902

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

alexgarel
Copy link
Member

No description provided.

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 additives 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling labels status system Products have a number of completion states, eg: https://world.openfoodfacts.org/states 🧽 Data quality https://wiki.openfoodfacts.org/Quality Ingredients processing labels Mar 12, 2024
@alexgarel alexgarel requested a review from aleene March 12, 2024 09:41
@alexgarel alexgarel changed the title taxonomies: fix taxonomies for lines double for same langage taxonomy: fix taxonomies for lines double for same langage Mar 12, 2024
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@@ -37380,7 +37375,7 @@ et:jõhvikas, harilik jõhvikas
fa:کرنبری
fi:karpalo, karpalot
fo:tranuber
fr:airelles, cranberries, cranberry, cranberrys, canneberge
fr:airelles, cranberries, cranberry, cranberrys, canneberge, Canneberge crue, Cranberry crue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

airelles and canneberges are different fruits

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moon-rabbitOFF We currently mix "airelles" and "canneberges" before this PR, so I suggest we merge it as-is, and it would be great if you could create another PR that would make the distinction between airelles and canneberges. From reading https://fr.wikipedia.org/wiki/Vaccinium I'm completely lost..

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for repairing all those issues. :)

@alexgarel alexgarel enabled auto-merge (squash) March 12, 2024 13:36
@stephanegigandet stephanegigandet dismissed moon-rabbitOFF’s stale review March 12, 2024 13:51

suggested changes will be done in a separate PR

@alexgarel alexgarel merged commit 55b66c9 into main Mar 12, 2024
12 checks passed
@alexgarel alexgarel deleted the taxonomies-remove-doubles branch March 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 additives 🧽 Data quality https://wiki.openfoodfacts.org/Quality Ingredients processing labels 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling status system Products have a number of completion states, eg: https://world.openfoodfacts.org/states 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants