Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove JS script loaded twice #9909

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: remove JS script loaded twice #9909

merged 1 commit into from
Mar 13, 2024

Conversation

stephanegigandet
Copy link
Contributor

I made a mistake and loaded the product-history script twice, which caused a JS error.

@stephanegigandet stephanegigandet requested a review from a team as a code owner March 13, 2024 11:57
@github-actions github-actions bot added Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. labels Mar 13, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

alexgarel
alexgarel approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexgarel alexgarel merged commit bb63130 into main Mar 13, 2024
13 checks passed
@alexgarel alexgarel deleted the remove-extra-js branch March 13, 2024 12:33
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Mar 13, 2024
Merged
@stephanegigandet stephanegigandet mentioned this pull request Mar 15, 2024
Merged
john-gom pushed a commit that referenced this pull request May 24, 2024
@stephanegigandet @john-gom
fix: remove JS script loaded twice (#9909)
a1cc574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
Product Page Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanegigandet @alexgarel