Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run off-pro through docker #9956

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix: run off-pro through docker #9956

merged 4 commits into from
Mar 26, 2024

Conversation

stephanegigandet
Copy link
Contributor

Somes changes to try to get "make dev" work after running

The sftp folder is created in order to avoid having an error at startup:

Log::Any::Proxy=HASH(0x55a4ed4a7fe0)[Tue Mar 19 13:09:54.189902 2024] [perl:error] [pid 17] FATAL: Some important directories are missing: /mnt/podata/sftp at /opt/product-opener/lib/startup_apache2.pl line 159.\nCompilation failed in require at (eval 2) line 1.\n

And we skip the import_sample_data

@stephanegigandet stephanegigandet requested a review from a team as a code owner March 19, 2024 13:21
@github-actions github-actions bot added 🐋 Docker https://docker-curriculum.com/ 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 💥 Merge Conflicts 💥 Merge Conflicts labels Mar 19, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

I have a suggestion to fix the Makefile to support multiple prefixes.

Makefile Outdated Show resolved Hide resolved
@alexgarel alexgarel enabled auto-merge (squash) March 26, 2024 15:32
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 26, 2024
@alexgarel alexgarel merged commit f18fb74 into main Mar 26, 2024
12 checks passed
@alexgarel alexgarel deleted the off-pro-docker branch March 26, 2024 16:03
john-gom pushed a commit that referenced this pull request May 24, 2024
Somes changes to try to get "make dev" work after running `. env/setenv.sh off-pro`:
* The sftp folder is created in order to avoid having an error at startup:
* And we skip the import_sample_data

---------

Co-authored-by: Alex Garel <[email protected]>
@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🐋 Docker https://docker-curriculum.com/ GS1 The producer platform is integrating with the GS1 product data formats. GS1 manages barcodes. 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
Development

Successfully merging this pull request may close these issues.

4 participants