Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display uuid in addition to User id in product edit history #9978

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

deveshidwivedi
Copy link
Contributor

What

This update ensures that both userid and uuid are displayed while editing a product, providing a more comprehensive view of user information within the application.

Screenshot

Related issue(s) and discussion

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.49%. Comparing base (dc04d18) to head (5e21656).
Report is 144 commits behind head on main.

Files Patch % Lines
lib/ProductOpener/Display.pm 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9978      +/-   ##
==========================================
- Coverage   49.54%   49.49%   -0.06%     
==========================================
  Files          67       71       +4     
  Lines       20650    20936     +286     
  Branches     4980     5020      +40     
==========================================
+ Hits        10231    10362     +131     
- Misses       9131     9277     +146     
- Partials     1288     1297       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@deveshidwivedi
Copy link
Contributor Author

Please take a look @stephanegigandet

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

I tested it, and it works :-)

image

@alexgarel alexgarel merged commit 3d3f461 into openfoodfacts:main Mar 25, 2024
11 of 12 checks passed
@deveshidwivedi deveshidwivedi deleted the uuid_display branch March 25, 2024 17:12
@teolemon teolemon added the product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements label Apr 26, 2024
john-gom pushed a commit that referenced this pull request May 24, 2024
)

This update ensures that both userid and uuid are displayed while editing a product, providing a more comprehensive view of user information within the application.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Display app_name and app_uuid in edit history
4 participants