Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loader in search-results #209

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat: add loader in search-results #209

merged 2 commits into from
Jul 4, 2024

Conversation

Kout95
Copy link
Collaborator

@Kout95 Kout95 commented Jul 1, 2024

What

  • Add loader in search-results

Screenshot

off_loading

Part of

@Kout95 Kout95 marked this pull request as ready for review July 1, 2024 09:16
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation !

@alexgarel alexgarel merged commit 0ee92b5 into main Jul 4, 2024
8 checks passed
@alexgarel alexgarel deleted the loader branch July 4, 2024 09:56
alexgarel pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](v1.3.0...v1.4.0)
(2024-07-25)


### Features

* add default images for products without image in off.html
[#208](#208)
([#220](#220))
([e4456f3](e4456f3))
* add loader in search-results
([#209](#209))
([0ee92b5](0ee92b5))
* be able to create scatter plots
([#189](#189))
([92e1c1b](92e1c1b))
* hide chart when search is not launched
([#214](#214))
([468a4c6](468a4c6))
* update count and refacto code with Signal
([#203](#203))
([9fbec21](9fbec21))


### Bug Fixes

* move docs and fix content
([#215](#215))
([2bc06c3](2bc06c3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants