Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make queue manager a standalone process #23

Merged
merged 2 commits into from
Nov 4, 2022
Merged

feat: make queue manager a standalone process #23

merged 2 commits into from
Nov 4, 2022

Conversation

alexgarel
Copy link
Member

This is a more robust approach.

@simonj2 I think the thread architecture was really fragile for something important to monitor in production.

@alexgarel alexgarel changed the title feat: make queue manager a standalone process feat: make queue manager a standalone process Oct 14, 2022
simonj2
simonj2 approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@simonj2 simonj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

app/import_queue/queue_manager.py Show resolved Hide resolved
app/import_queue/queue_manager.py Show resolved Hide resolved
app/import_queue/queue_manager.py Outdated Show resolved Hide resolved
@alexgarel alexgarel merged commit 3a588ab into main Nov 4, 2022
@alexgarel alexgarel deleted the feat-standalone-queue branch November 4, 2022 16:38
@github-actions github-actions bot mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonj2 simonj2 simonj2 approved these changes

Assignees

@alexgarel alexgarel

Labels
None yet
Projects
🔎 Search-a-licious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexgarel @simonj2