Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching between portion/100g, the table should change immediately #1307

Closed
teolemon opened this issue Mar 23, 2022 · 7 comments
Closed
Labels
🐛 bug Something isn't working nutrition facts P3
Milestone

Comments

@teolemon
Copy link
Member

teolemon commented Mar 23, 2022

What

  • The dropdown experience is not very intuitive
  • When switching the quantity between portion/100g, the table should change immediately, not when I release my thumb

Video

screen-20220322-185845.mp4

Part of

@g123k
Copy link
Collaborator

g123k commented Mar 23, 2022

On Android, we have a switch for this toggle, but we don't have enough space here.
A dialog would be perfect here, I guess. Any suggestion otherwise?

@monsieurtanuki
Copy link
Contributor

Radio buttons on a column?

@stephanegigandet
Copy link
Contributor

Maybe we can think more about the actual use of this.
Some users want to see data per 100g, because they are used to it, they can quickly see the % of sugars etc.
Others are more interested in the per serving, (also because they are used to it), because they count calories etc.

But it's very likely that this is a global user preference, it does not change on a product per product basis.

So maybe we could think of it like that: a user preference. And to make it visible, we could display a switch or something just
above the table.

The switch has the advantage of making that choice understandable and visible. With the dropdown, I first have to click on that "100g" to understand that I can change it to per serving.

The dialog idea is also interesting because we could use it to extra features (e.g. computing values for any quantity, which could appeal to some users)

@monsieurtanuki
Copy link
Contributor

In order to go a bit further on @stephanegigandet's path, that could mean

  • displaying the current choice ("100g", "60g serving") and then the "edit" icon (to make it clear that it's editable) (even like an ElevatedButton?)
  • when clicking on that serving button, open a dialog with at least two app-level choices ("100g" or "serving")
  • how could we put in the same dialog a specific user-defined serving size for this product? (which would be a "nice to have")

Suggestion for the dialog:

Preference on app level:
100g Capture d’écran 2022-03-24 à 18 19 51 serving size

Capture d’écran 2022-03-24 à 18 23 09 Custom serving size for that specific product:
[ 30]g

@teolemon teolemon added this to the V1 milestone Apr 4, 2022
@teolemon teolemon changed the title The dropdown experience is not very intuitive When switching between portion/100g, the table should change immediately Apr 22, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@teolemon teolemon added the 🐛 bug Something isn't working label Aug 7, 2022
@teolemon
Copy link
Member Author

teolemon commented Aug 7, 2022

@monsieurtanuki
Copy link
Contributor

The problem is that we don't have enough space for 4 columns (3 columns is the apparent limit):

  1. nutrient name
  2. value per 100g
  3. value per serving
  4. comparison

I guess we could easily add a switch (serving / comparison) on top of the table.

The display would then either be:

  1. nutrient name
  2. value per 100g
  3. value per serving

or

  1. nutrient name
  2. value per 100g
  3. comparison

@M123-dev
Copy link
Member

M123-dev commented Oct 4, 2022

We now have a gramm picker

@M123-dev M123-dev closed this as completed Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working nutrition facts P3
Development

No branches or pull requests

6 participants