Cropping images takes an unholy amount of time (30s+)

[teolemon]

What

• Cropping images takes an unholy amount of time (30s+)

Steps to reproduce the behavior

1. Go to product page
2. Take more photos from carousel
3. Take and crop photo
4. Wait
5. Wait
6. Wait again
7. Start screaming

Expected behavior

• Not waiting

Why

• Alex wants free time

Part of

• Product addition (tracker) #1379

Video

• https://photos.app.goo.gl/tKoED9mBVgV6Dnnu6 (The video is in French, but it gives you an opportunity to learn counting to 30 in French)

Smartphone model

• Device: Huawei Y7
• OS: Android 8.0
• WiFi
• App Version 0.0.3 (242)

[M123-dev]

Thats a long time indeed. I just check it is actually pretty quick on my phone so it's a overall performance thing and no problem in our code. But good news, if we decide to switch back to a native scanner as the idea came up in #1400 the performance should get a little bit better

[teolemon]

The question is:

• would there be a way to optimize performance by reducing the size of the image ?
• how much can we reduce that size?

[monsieurtanuki]

For my own app I coded my own cropping tools, with immediate results: please have a go with app "Camino Logo".
That said, the slow part is when you actually create a new JPEG (or PNG, can't remember) from your original picture and cropping parameters. That's maybe part of your problem @teolemon, with a smartphone with high definition: tons of pixels.

[monsieurtanuki]

@teolemon Beyond your frustration of "it takes a looooooong time", I can detect other types of worries:

• "What's going on? I can't even remember what I clicked. Which step is being processed? Perhaps it crashed and I cannot see it? Is there a percentage?"
• "I would like to stop that NOW!"

Again, the use of LoadingDialog or something similar would be much better - UX-wise - than just a CircularProgressIndicator.
And we should make a smoothie standard out of it.

[teolemon]

(It was actually reported by @alexgarel, I was merely the expert videographer 🙃 )

• It's very much the same kind of topic as in (Product Addition) The "uploading image" dialog should not block the user from moving to the next photo #1393
• Rather than asking people to wait, we should remove the underlying cause, or avoid talking about completion when it's possible (and only talk about good news once it's done)
• In that case, with crop, that's not possible, but I would almost put a "Still working" message (possibly with a spinner, and a numeric progress) inline to avoid popup induced claustrophobia

[monsieurtanuki]

Rather than asking people to wait, we should remove the underlying cause

Sure. There are also other cases when we do need a "cancel" button, e.g. while downloading with a very slow internet.

put a "Still working" message [...] inline to avoid popup induced claustrophobia

I understand how aggressive a pop-up may appear. You can still put a "cancel" button on your message.

Basically, what we need is a "smooth" snackbar. But still, we should be able to kind of freeze the rest of the screen, unless you're very comfortable with several parallel actions. That's why the modal dialog was a good choice in a first approach. To be fine-tuned...