Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "Null" brand with an Unknown brand #2164

Open
g123k opened this issue Jun 5, 2022 · 5 comments
Open

replace "Null" brand with an Unknown brand #2164

g123k opened this issue Jun 5, 2022 · 5 comments

Comments

@g123k
Copy link
Collaborator

g123k commented Jun 5, 2022

What

  • It seems that some products in the database belong to a "Null" brand.
  • In that case, shouldn't we replace this data issue with an Unknown brand or something like that?

Part of

@teolemon
Copy link
Member

teolemon commented Jun 5, 2022

Yes 👌

@teolemon
Copy link
Member

teolemon commented Jun 5, 2022

It seems to be the "Gluten Scan" app.

  • I'm going to file a cleanup task
  • I'm going to notify the dev as well

@g123k
Copy link
Collaborator Author

g123k commented Jun 5, 2022

I wonder where we should fix this: on the Dart dependency or this app.
Any suggestion?

@teolemon
Copy link
Member

teolemon commented Jun 5, 2022

It's a low volume of products(300), so we can postpone to be honest

@g123k
Copy link
Collaborator Author

g123k commented Jun 5, 2022

What I mean by that, is maybe to prevent entering "null" values on the "Dart" side, to ensure nobody fill the database with incorrect values. For Smoothie, that's another thing

@teolemon teolemon changed the title "Null" brand replace "Null" brand with an Unknown brand Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Status: To do
Development

No branches or pull requests

2 participants