Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull to refresh in the photo manager in edit mode #2998

Closed
teolemon opened this issue Sep 11, 2022 · 2 comments · Fixed by #3023
Closed

Add pull to refresh in the photo manager in edit mode #2998

teolemon opened this issue Sep 11, 2022 · 2 comments · Fixed by #3023

Comments

@teolemon
Copy link
Member

teolemon commented Sep 11, 2022

What

  • Add pull to refresh in the photo manager in edit mode

Why

  • It's not refreshed automatically when the image upload is complete, leading the user to believe it did not work.

Related to

Part of

@AshAman999
Copy link
Member

@teolemon @M123-dev
I was working on this workaround, for a while

  • We change the placeholder images there immediately with the ones from file images that we have, till we delete them after the background process finishes,
  • Use UptodateProductProvider to rebuild the whole product widget/gallery once the image upload task is done, I think Mr. Monsieurtanuki is working on that for now,
  • Added benefits will be, even if the user is offline if he adds a picture it will show him immediately

If this approach looks okay, then I could probably go and make a fresh clean code pr for this feat.

20220915_123546.mp4

@M123-dev
Copy link
Member

Sounds good to me @AshAman999 but we should still add a pull to refresh gesture just that it's the same behaviour on all edit pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants