Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing producer provided and protected fields #5430

Open
teolemon opened this issue Jun 21, 2024 · 5 comments
Open

Add support for showing producer provided and protected fields #5430

teolemon opened this issue Jun 21, 2024 · 5 comments
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users protected products ⭐ top issue Top issue.

Comments

@teolemon
Copy link
Member

teolemon commented Jun 21, 2024

Problem

Mockups

image

Part of

@teolemon teolemon added the ✨ enhancement New feature or request label Jun 21, 2024
@teolemon teolemon transferred this issue from openfoodfacts/open-prices-frontend Jun 21, 2024
@teolemon teolemon added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Jun 21, 2024
@VaiTon
Copy link
Member

VaiTon commented Jul 16, 2024

@github-actions github-actions bot added the ⭐ top issue Top issue. label Jul 20, 2024
@M123-dev M123-dev added the Blocked on Dart API Issues that are blocked on the dart api implementation label Jul 29, 2024
@M123-dev
Copy link
Member

Waiting for: openfoodfacts/openfoodfacts-dart#956

@monsieurtanuki monsieurtanuki removed the Blocked on Dart API Issues that are blocked on the dart api implementation label Aug 13, 2024
@monsieurtanuki
Copy link
Contributor

I don't know how we are supposed to display the "owner fields".

current display display with "owner locked" fields
Screenshot_1723565488 Screenshot_1723565436

@teolemon
Copy link
Member Author

  • something we've never done is a replicate the product edit history you have at the bottom of the product page in the web version.
  • in the web the product owner is displayed in a warning tooltip (some of the database product has been provided by the producer blah)
  • I would believe that all of this should be less prominent than on the web version and possibly at the bottom of the page or in a special tab if we follow the proof of concept design.

@monsieurtanuki
Copy link
Contributor

something we've never done is a replicate the product edit history you have at the bottom of the product page in the web version.

That would definitely deserve a separate issue. Plus a lot of additional code in off-dart (specifically for "product image for version x"). That would be for hard-core users, that have an interest in previous versions.

in the web the product owner is displayed in a warning tooltip (some of the database product has been provided by the producer blah)

Instead of the lock icon we could use an info icon, with an info dialog.

I would believe that all of this should be less prominent than on the web version and possibly at the bottom of the page or in a special tab if we follow the proof of concept design.

I thought the point was to say: that specific field cannot be changed as it is provided by the producer.
If we display a generic message and let the users (try to) change the values regardless, we'll still have the not-so-funny "background tasks do not work" complaints.

@teolemon teolemon removed the ✨ enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users protected products ⭐ top issue Top issue.
Projects
Status: Backlog
Status: 💬 To discuss and validate
Development

No branches or pull requests

4 participants