-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 5643 - edit of products of any product type #5661
Merged
Merged
+210
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `add_basic_details_page.dart`: added product type * `add_new_product_page.dart`: added a "set product type page" for new products; added product type; minor refactoring * `add_other_details_page.dart`: added product type * `app_en.arb`: added 1 label per product type, and 4 labels for product type input * `background_task_barcode.dart`: added product type * `background_task_crop.dart`: added product type * `background_task_details.dart`: added product type * `background_task_hunger_games.dart`: added product type * `background_task_image.dart`: added product type * `background_task_refresh_later.dart`: added product type * `background_task_unselect.dart`: added product type * `background_task_upload.dart`: added product type * `edit_new_packagings.dart`: added product type * `edit_ocr_page.dart`: added product type * `image_crop_page.dart`: added product type * `nutrition_page_loaded.dart`: added product type * `product_crop_helper.dart`: added product type * `product_dialog_helper.dart`: removed irrelevant nutriscore and ecoscore logos for new found products, as we cannot say already if it's food * `product_image_button.dart`: added product type * `product_image_carousel_item.dart`: added product type * `product_image_crop_button.dart`: added product type * `product_image_gallery_view.dart`: added product type * `product_image_local_button.dart`: added product type * `product_image_unselect_button.dart`: added product type * `product_image_viewer.dart`: added product type * `product_query.dart`: localized labels for product type * `simple_input_page.dart`: added product type * `simple_input_page_helpers.dart`: added product type * `up_to_date_changes.dart`: added product type * `uploaded_image_gallery.dart`: added product type
github-actions
bot
added
🥫 Product page
Product addition
The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
✏️ Editing - Nutrition input
🖼️ Photos - Cropping
✏️ Editing - Basic info input
✏️ Editing - 📦 Packaging input
🔁 Background tasks
OCR page
labels
Oct 2, 2024
teolemon
added
🧴 Open Beauty Facts
Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378
📸 Open Products Facts
🐾 Open Pet Food Facts
OxF
labels
Oct 2, 2024
teolemon
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 👏
🍾 🧴 🐱 📸
really cool.
Thank you @teolemon for your quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔁 Background tasks
✏️ Editing - Basic info input
✏️ Editing - Nutrition input
✏️ Editing - 📦 Packaging input
OCR page
🧴 Open Beauty Facts
Please see this proposal: https://github.com/openfoodfacts/smooth-app/discussions/1378
🐾 Open Pet Food Facts
📸 Open Products Facts
OxF
🖼️ Photos - Cropping
Product addition
The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
🥫 Product page
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshots
Part of
Impacted files
add_basic_details_page.dart
: added product typeadd_new_product_page.dart
: added a "set product type page" for new products; added product type; minor refactoringadd_other_details_page.dart
: added product typeapp_en.arb
: added 1 label per product type, and 4 labels for product type inputbackground_task_barcode.dart
: added product typebackground_task_crop.dart
: added product typebackground_task_details.dart
: added product typebackground_task_hunger_games.dart
: added product typebackground_task_image.dart
: added product typebackground_task_refresh_later.dart
: added product typebackground_task_unselect.dart
: added product typebackground_task_upload.dart
: added product typeedit_new_packagings.dart
: added product typeedit_ocr_page.dart
: added product typeimage_crop_page.dart
: added product typenutrition_page_loaded.dart
: added product typeproduct_crop_helper.dart
: added product typeproduct_dialog_helper.dart
: removed irrelevant nutriscore and ecoscore logos for new found products, as we cannot say already if it's foodproduct_image_button.dart
: added product typeproduct_image_carousel_item.dart
: added product typeproduct_image_crop_button.dart
: added product typeproduct_image_gallery_view.dart
: added product typeproduct_image_local_button.dart
: added product typeproduct_image_unselect_button.dart
: added product typeproduct_image_viewer.dart
: added product typeproduct_query.dart
: localized labels for product typesimple_input_page.dart
: added product typesimple_input_page_helpers.dart
: added product typeup_to_date_changes.dart
: added product typeuploaded_image_gallery.dart
: added product type