fix: 5665 - display "add nutrition facts" button only for relevant types #5674
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `add_nutrition_button.dart`: new method to check if nutrition facts are relevant for this product type * `knowledge_panel_action_card.dart`: checks if the product type matches before displaying the nutrition facts button * `knowledge_panels_builder.dart`: checks if the product type matches before displaying the nutrition facts button * `pubspec.lock`: upgrade to flutter `3.24`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5674 +/- ##
==========================================
- Coverage 9.54% 6.79% -2.76%
==========================================
Files 325 404 +79
Lines 16411 21583 +5172
==========================================
- Hits 1567 1466 -101
- Misses 14844 20117 +5273 ☔ View full report in Codecov by Sentry. |
teolemon
approved these changes
Oct 19, 2024
|
Thanks @monsieurtanuki 👌 |
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes bug(s)
Impacted files
add_nutrition_button.dart: new method to check if nutrition facts are relevant for this product typeknowledge_panel_action_card.dart: checks if the product type matches before displaying the nutrition facts buttonknowledge_panels_builder.dart: checks if the product type matches before displaying the nutrition facts buttonpubspec.lock: upgrade to flutter3.24