feat: 5326 - users can now select proof from gallery in "add price" page #5679
+174
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `image_crop_page.dart`: now we can force the image source * `price_model.dart`: now we can set a proof after init time * `price_proof_card.dart`: now we can select the proof image among "camera", "gallery" and "my proofs"; minor refactoring * `prices_proofs_page.dart`: added a "select proof?" parameter to pop the selected proof if needed * `user_preferences_account.dart`: minor refactoring
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5679 +/- ##
==========================================
- Coverage 9.54% 6.80% -2.75%
==========================================
Files 325 404 +79
Lines 16411 21550 +5139
==========================================
- Hits 1567 1466 -101
- Misses 14844 20084 +5240 ☔ View full report in Codecov by Sentry. |
|
Thank you @teolemon for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Screenshot
Fixes bug(s)
Impacted files
image_crop_page.dart: now we can force the image sourceprice_model.dart: now we can set a proof after init timeprice_proof_card.dart: now we can select the proof image among "camera", "gallery" and "my proofs"; minor refactoringprices_proofs_page.dart: added a "select proof?" parameter to pop the selected proof if neededuser_preferences_account.dart: minor refactoring