-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 5693 - able to run tasks without minimum duration wait #5694
fix: 5693 - able to run tasks without minimum duration wait #5694
Conversation
Impacted files: * `background_task_manager.dart`: made it possible to force an immediate run if possible * `offline_tasks_page.dart`: force an immediate run if possible when clicking on the refresh button
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5694 +/- ##
==========================================
- Coverage 9.54% 6.95% -2.60%
==========================================
Files 325 404 +79
Lines 16411 21589 +5178
==========================================
- Hits 1567 1502 -65
- Misses 14844 20087 +5243 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description sounds enticing, and if we really did that, then that could explain some of the PlayStore complaints. We should really aim for instant results, and honesty in our messaging (perhaps a "changes submitted indicator" ?)
Thank you @teolemon for your review!
thanks
I don't think so, unless the complaints were targeted at Prices and during a specific month when we refreshed the background tasks "too early".
Probably worth a specific issue. |
What
Fixes bug(s)
Impacted files
background_task_manager.dart
: made it possible to force an immediate run if possibleoffline_tasks_page.dart
: force an immediate run if possible when clicking on the refresh button